RFR: [backport] 8044775: Improve usage of umbrella header atomic.inline.hpp.

[David Holmes]

Hi Goetz,

On 18/09/2014 5:06 PM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
>
> I guess that's the major reason ... also other backports will apply better.
> Finally SAP will get the change earlier as we'll do 8u40 long before 9.
>
> But if you object we can just skip it, as it's not a bugfix it's not a big deal.

I think the issue is that 8u40 has hit feature complete (or will before 
any new changes to hotspot will make it into the master repo [1]), so 
only bug fixes should be accepted from this point forward.

Once jdk8u/dev is open for 8u60 changes then this could be backported.

Cheers,
David

[1] http://openjdk.java.net/projects/jdk8u/releases/8u40.html

> Best regards,
>    Goetz.
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: Donnerstag, 18. September 2014 07:41
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR: [backport] 8044775: Improve usage of umbrella header atomic.inline.hpp.
>
> Goetz,
>
> These 2 changes are not bugs fixes. Why do you want to backport them (excluding "to keep code similar")?
>
> Thanks,
> Vladimir
>
> On 9/17/14 2:27 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> I'd like to backport this change:
>> JDK-8044775: Improve usage of umbrella header atomic.inline.hpp.
>>
>> It did not apply cleanly, so I please need a review:
>>
>> Some files do not exist in 8 or don't exist any more:
>>     src/share/vm/classfile/stringTable.cpp
>>     src/share/vm/service/memPtr.hpp
>>     src/share/vm/service/memPtr.cpp
>>     src/share/vm/service/memRecorder.cpp
>>
>> In some files the patch did not apply cleanly, as the context
>> changed:
>>     src/share/vm/utilities/bitMap.cpp
>>     src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
>>     src/share/vm/oops/instanceKlass.cpp
>>
>> Here usage of class Atomic was removed along with the header:
>>     src/share/vm/service/memTracker.cpp
>>
>> This is the webrev for the 8u repository:
>> http://cr.openjdk.java.net/~goetz/webrevs/8044775-atomInc/webrev.8.00/
>>
>> This is the  change in 9:
>> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/b596a1063e90
>> and the webrev sumitted to 9:
>> http://cr.openjdk.java.net/~goetz/webrevs/8044775-atomInc/webrev.01/
>>
>> Please review this.  I  please need a sponsor to push the change.
>>
>> Best regards,
>>     Goetz.
>>
>>
>>
>>