[9] RFR(S): 8059137: MemoryPoolMXBeans for different code heaps should contain 'Code heap' in their names

Filipp Zhinkin filipp.zhinkin at oracle.com
Mon Sep 29 11:56:17 UTC 2014


Hi Tobias,

thank you for taking care of it. The change looks good.

Regards,
Filipp.

On 09/29/2014 02:08 PM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8059137
> Webrev: http://cr.openjdk.java.net/~thartmann/8059137/webrev.00/
>
> == Problem ==
> The segmented code cache implementation registers a memory pool for each code 
> heap. To be consistent with the "non-segmented" output, the names of these 
> pools should contain the word "code heap".
>
> == Solution ==
> I added "Code Heap" to the name of the segments. The output now looks like this:
>
> $ /export/bin/java -XX:-SegmentedCodeCache Test
> Code Cache
> [...]
>
> $ /export/bin/java -XX:+SegmentedCodeCache Test
> Code Heap 'non-methods'
> Code Heap 'profiled nmethods'
> Code Heap 'non-profiled nmethods'
> [...]
>
> Thanks,
> Tobias



More information about the hotspot-dev mailing list