RFR: 8058606 Detailed Native Memory Tracking (NMT) data is not output at VM exit

Lois Foltan lois.foltan at oracle.com
Mon Sep 29 13:17:13 UTC 2014


Hi George,

src/share/vm/services/memTracker.cpp
     - I don't see where the variable mem_baseline is initialized before 
you invoke the method baseline()?  I am not
       overly familiar with NMT but it looks like your might need to do 
something like: MemBaseline& baseline = MemTracker::get_baseline();

     - Your indentation for your edits at least in the webrev looks very 
off

Thanks,
Lois

On 9/29/2014 7:55 AM, George Triantafillou wrote:
> Please review this fix for JDK-8058606.  The output from the 
> -XX:NativeMemoryTracking=detail option now outputs detailed tracking 
> information at VM exit. Previously, only summary tracking information 
> was output.
>
> A new test was added to verify the output from both summary and detail 
> tracking options.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8058606
> Webrev: http://cr.openjdk.java.net/~gtriantafill/8058606/webrev/
>
> <http://cr.openjdk.java.net/%7Egtriantafill/8058606/webrev/>The fix 
> was tested locally on Linux with jtreg and the JPRT hotspot testset.
>
> -George



More information about the hotspot-dev mailing list