RFR(XXS): 8076532: Fix format warning/error in methodHandles_ppc.cpp

[Volker Simonis]

Thanks David!

Volker


On Thu, Apr 2, 2015 at 11:17 AM, David Holmes <david.holmes at oracle.com> wrote:
> Looks fine Volker!
>
> Thanks,
> David
>
>
> On 2/04/2015 7:12 PM, Volker Simonis wrote:
>>
>> Hi,
>>
>> can I please get a review for this tiny, ppc-only change:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8076532
>> http://cr.openjdk.java.net/~simonis/webrevs/2015/8076532/
>>
>> With newer GCCs we currently get the following warning/error:
>>
>> methodHandles_ppc.cpp: In function ‘void
>> trace_method_handle_stub(const char*, oopDesc*, intptr_t*,
>> intptr_t*)’:
>> methodHandles_ppc.cpp:469:66: error: format ‘%lx’ expects argument of
>> type ‘long unsigned int’, but argument 6 has type ‘intptr_t* {aka long
>> int*}’ [-Werror=format=]
>>                   adaptername, mh_reg_name, (intptr_t) mh, entry_sp);
>>
>> for this code code in methodHandles_ppc.cpp:
>>
>>    tty->print_cr("MH %s %s="INTPTR_FORMAT " sp=" INTPTR_FORMAT,
>>                  adaptername, mh_reg_name, (intptr_t) mh, entry_sp);
>>
>> The fix is trivial - just use the "p2i()" helper function to cast the
>> pointers to the appropriate type:
>>
>>    tty->print_cr("MH %s %s="INTPTR_FORMAT " sp=" INTPTR_FORMAT,
>>                  adaptername, mh_reg_name, p2i(mh), p2i(entry_sp));
>>
>>
>> Thanks,
>> Volker
>>
>