RFR: 8077364 "if( !this )" construct prevents build on Xcode 6.3

[Volker Simonis]

Hi Staffan,

the change looks good, but the list of compiler versions for which we
need a the same workaround seems to get a little bit long. Shouldn't
we change that to something like:

# Clang <= 6.1
ifeq ($(shell expr $(CC_VER_MAJOR) \< 6 \| \( $(CC_VER_MAJOR) = 6 \&
$(CC_VER_MINOR) \<= 1 \) ), 1)
  OPT_CFLAGS/loopTransform.o += $(OPT_CFLAGS/NOOPT)
  OPT_CFLAGS/unsafe.o += -O1
else
  $(error "Update compiler workarounds for Clang
$(CC_VER_MAJOR).$(CC_VER_MINOR)")
endif

Regards,
Volker


On Tue, Apr 14, 2015 at 9:54 AM, Staffan Larsen
<staffan.larsen at oracle.com> wrote:
> Please review this fix for compiling hotspot with clang 6.1.
>
> I have verified that the compiler workarounds are still needed for these tests:
> jdk/test/sun/misc/CopyMemory.java
> hotspot/test/compiler/c2/5091921/
>
> webrev: http://cr.openjdk.java.net/~sla/8077364/webrev.00 <http://cr.openjdk.java.net/~sla/8077364/webrev.00>
> bug: https://bugs.openjdk.java.net/browse/JDK-8077364 <https://bugs.openjdk.java.net/browse/JDK-8077364>
>
> Thanks,
> /Staffan
>