RFR: 8077364 "if( !this )" construct prevents build on Xcode 6.3
Staffan Larsen
staffan.larsen at oracle.com
Tue Apr 14 09:19:15 UTC 2015
Stefan, Volker: Thanks for the suggestions and spotting the errors.
new webrev: http://cr.openjdk.java.net/~sla/8077364/webrev.01/ <http://cr.openjdk.java.net/~sla/8077364/webrev.01/>
Thanks,
/Staffan
> On 14 apr 2015, at 10:54, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>
> Hi Staffan,
>
> On 2015-04-14 09:54, Staffan Larsen wrote:
>> Please review this fix for compiling hotspot with clang 6.1.
>>
>> I have verified that the compiler workarounds are still needed for these tests:
>> jdk/test/sun/misc/CopyMemory.java
>> hotspot/test/compiler/c2/5091921/
>>
>> webrev: http://cr.openjdk.java.net/~sla/8077364/webrev.00 <http://cr.openjdk.java.net/~sla/8077364/webrev.00>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8077364 <https://bugs.openjdk.java.net/browse/JDK-8077364>
>
> What about this code that is protected by #ifndef PRODUCT
>
> char *PhaseChaitin::dump_register( const Node *n, char *buf ) const {
> if( !this ) { // Not got anything?
> sprintf(buf,"N%d",n->_idx); // Then use Node index
> }
>
> Thanks,
> StefanK
>
>>
>> Thanks,
>> /Staffan
>>
>
More information about the hotspot-dev
mailing list