RFR(M): 8059047: Extract parser/validator from jhat for use in tests
Yekaterina Kantserova
yekaterina.kantserova at oracle.com
Wed Apr 22 12:25:05 UTC 2015
Staffan, thank you for the review!
This issue needs a change in jdk as well.
http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.00 -
BasicJMapTest.java will use HprofParser to verify hprof dumps created by
the test.
// Katja
On 04/22/2015 01:20 PM, Staffan Larsen wrote:
> Looks good!
>
> Thanks,
> /Staffan
>
>> On 22 apr 2015, at 11:17, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>>
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8059047
>> webrev: http://cr.openjdk.java.net/~ykantser/8059047/webrev.00/
>>
>> This fix is a part of JEP 241: Remove the jhat Tool (https://bugs.openjdk.java.net/browse/JDK-8059039). I suggest to put parser/validator into common test library since the functionality can be useful not only for SVC tools tests but even for some future GC tests.
>>
>> The old jhat packages have been moved as follows:
>> com.sun.tools.hat.internal.model -> jdk.test.lib.hprof.model
>> com.sun.tools.hat.internal.parser -> jdk.test.lib.hprof.parser
>> com.sun.tools.hat.internal.util -> jdk.test.lib.hprof.util
>>
>> The source has not been changed except Copyrights year.
>>
>> Thanks,
>> Katja
More information about the hotspot-dev
mailing list