RFR(L): 8077838: Recent developments for ppc.

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Apr 23 08:27:51 UTC 2015


Hi Vladimir, 

thanks for the review!

These methods actually do an atomic update of a memory location, so the name
really describes what is happening.

I'll remove the change to  interpreter_ppc.cpp and runtime_ppc.cpp.

Best regards,
  Goetz

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Donnerstag, 23. April 2015 01:16
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(L): 8077838: Recent developments for ppc.

Why call methods 'atomic': atomic_inc_ptr() and atomic_ori_int()?

Do you really need to change runtime_ppc.cpp only to remove empty line?

Looks fine otherwise.

Vladimir

On 4/22/15 2:34 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> this change contains recent changes in the ppc directory mostly made by SAP.
> It's a ppc-only change.
> http://cr.openjdk.java.net/~goetz/webrevs/8077838-ppc/webrev.01/
>
>   - Recognition of Power 8 processors (by Tiago Sturmer Daitx).
>   - Support for more new Power 8 instructions.
>   - Support for transactional memory. This is implemented but not yet tested
>     thoroughly due to limitiations of the OS support. Not enabled.
>   - java.lang.math.*Exact intrinsics
>   - Some C2 optimizations and fixes:
>     * Handling of flag registers. Some instructions would lead to uncompilable
>       methods due to not allocatable register patterns.
>     * Free some integer registers to use them for allocation. Handle compressed
>       oops base as constant.
>     * Unscaled class compression.
>   - Type profiling fixes.
>
> Please review this change.
>
> Best regards,
>    Goetz.
>
>


More information about the hotspot-dev mailing list