RFR(S): 8078482: ppc: pass thread to throw_AbstractMethodError

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Apr 23 15:02:32 UTC 2015


Okay. Looks good.

Thanks,
Vladimir

On 4/23/15 7:56 AM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
>
> Oh, I only mentioned that in the bug.
>
> The SIGSEGV was recognized as a Safepoint, because the check
> was not strict enough.  It crashed a second time  when trying to
> handle the safepoint.
>
> Because of some bug in an old linux we don't check the address
> accessed but the instruction doing the access.  I made this check
> more strict, i.e. I check whether it happened in an nmethod.
>
> Best regards,
>    Goetz.
>
>
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: Donnerstag, 23. April 2015 16:27
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR(S): 8078482: ppc: pass thread to throw_AbstractMethodError
>
> What is the change in os_linux_ppc.cpp?
>
> Vladimir
>
> On 4/23/15 1:35 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> this fixes an issue detected by Tiago Sturmer Daitix in the jdk7 ppc port.
>> The thread argument was left out in a call to throw_AbstractMethodError.
>>
>> Please review this change.  It needs to go to jdk8u, too.  It's ppc only.
>> http://cr.openjdk.java.net/~goetz/webrevs/8078482-fixAME/webrev.01/
>>
>> Best regards,
>>     Goetz.
>>


More information about the hotspot-dev mailing list