RFR (XXS): 8132969: C++11 requires a space between literal and identifier

[Volker Simonis]

Thanks a lot Christian!

Volker


On Tue, Aug 4, 2015 at 3:44 PM, Christian Tornqvist
<christian.tornqvist at oracle.com> wrote:
> This looks good, thanks for fixing this. I can sponsor the change for you.
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Volker Simonis
> Sent: Tuesday, August 4, 2015 9:41 AM
> To: Baesken, Matthias <matthias.baesken at sap.com>
> Cc: hotspot-dev at openjdk.java.net
> Subject: RFR (XXS): 8132969: C++11 requires a space between literal and identifier
>
> Hi Matthias,
>
> the change looks good. I've opened:
>
> https://bugs.openjdk.java.net/browse/JDK-8132969
>
> for it and created a webrev:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2015/8132969/
>
> We still need a second reviewer who can sponsor the change.
>
> Thanks,
> Volker
>
>
> On Mon, Aug 3, 2015 at 4:05 PM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
>> Hello, in
>>
>> "8081202 C++11 requires a space between literal and identifier", see
>>
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-May/018665.htm
>> l
>>
>> a number of places in hotspot coding with missing spaces between literals and identifiers were already fixed.
>>
>> When experimenting with Visual Studio 2015 (which refuses compiling such code) , I noticed that this fix is missing here :
>>
>> hotspot/src/share/vm/interpreter/interpreterRuntime.cpp
>>
>> The following small diff is fixing the remaining issue.
>>
>>
>> 1306c1306
>> <       tty->print_cr("argument handler #%d at "PTR_FORMAT" for fingerprint " UINT64_FORMAT,
>> ---
>>>       tty->print_cr("argument handler #%d at " PTR_FORMAT " for
>>> fingerprint " UINT64_FORMAT,
>> 1316c1316
>> <       tty->print_cr("duplicate argument handler #%d for fingerprint " UINT64_FORMAT "(old: "PTR_FORMAT", new : "PTR_FORMAT")",
>> ---
>>>       tty->print_cr("duplicate argument handler #%d for fingerprint "
>>> UINT64_FORMAT "(old: " PTR_FORMAT ", new : " PTR_FORMAT ")",
>>
>>
>> Could you please add  the small fix ?
>>
>> Thanks, Matthias
>