RFR (XS): 8133557: Missing test before a branch when checking for MethodCounters in TemplateTable::branch() on x86
Richard Reingruber
richard.reingruber at sap.com
Fri Aug 14 15:01:39 UTC 2015
Hi,
this is a request for review of the following fix for bug 8133557 (https://bugs.openjdk.java.net/browse/JDK-8133557).
diff -r af60f1cb36f2 src/cpu/x86/vm/templateTable_x86.cpp
--- a/src/cpu/x86/vm/templateTable_x86.cpp Mon Aug 10 10:39:19 2015 -0700
+++ b/src/cpu/x86/vm/templateTable_x86.cpp Fri Aug 14 10:46:47 2015 +0200
@@ -2014,6 +2014,7 @@
__ pop(rcx);
__ pop(rdx);
__ movptr(rax, Address(rcx, Method::method_counters_offset()));
+ __ testptr(rax, rax);
__ jcc(Assembler::zero, dispatch);
__ bind(has_counters);
Thanks,
Richard.
More information about the hotspot-dev
mailing list