RFR: JDK-8133669 - Remove unused code in Arguments

[David Holmes]

Looks good!

Thanks,
David

On 17/08/2015 11:31 PM, Jesper Wilhelmsson wrote:
> David, Kim,
>
> Thanks for the reviews!
>
> A new version with the method declaration removed is available here:
> http://cr.openjdk.java.net/~jwilhelm/8133669/webrev.01/
>
> Thanks,
> /Jesper
>
>
> David Holmes skrev den 17/8/15 06:44:
>> Hi Jesper,
>>
>> On 15/08/2015 3:12 AM, Jesper Wilhelmsson wrote:
>>> Hi,
>>>
>>> Please review this small removal of unused code in the argument parser.
>>> The variables Arguments::_min_heap_free_ratio and
>>> Arguments::_max_heap_free_ratio have no use after the flag verification
>>> changes. They can be removed together with
>>> Arguments::post_after_ergo_constraint_check() that is used to update
>>> them.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8133669
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8133669/webrev.00/
>>
>> As Gerard mentioned offlist arguments.hpp also needs to remove:
>>
>> // Set any arguments that need to be set after the
>> 'CommandLineFlagConstraint::AfterErgo' constraint check
>> static void post_after_ergo_constraint_check(bool check_passed);
>>
>> Otherwise the cleanup looks okay.
>>
>> Thanks,
>> David
>>
>>> Thanks,
>>> /Jesper