RFR: 8133646: Internal Error: x86/vm/macroAssembler_x86.cpp:886 DEBUG MESSAGE: StubRoutines::call_stub: threads must correspond

[Coleen Phillimore]

That's ok.
Reviewed
Coleen

Sent from my iPhone

> On Aug 25, 2015, at 10:17 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Coleen,
> 
> Thanks for the review.
> 
>> On 26/08/2015 2:28 AM, Coleen Phillimore wrote:
>> 
>> David,
>> Can you add this duplicate code into a verify_thread() function? This
>> would help if we are ever able to combine common code in
>> stubRoutines_x86_32/64.cpp
> 
> I'm so grateful you posed that as a question not a request. :) Answer: no.
> 
> The duplicated structure is pre-existing, and the error messages differ so the context would have to be passed in. I'm totally unfamiliar with playing in the macroassembler so would be unsure how to factor this out into a separate function without messing up register usage, or using the correct "variables" from the "calling context".
> 
> Also note that for some reason these sanity checks don't exist on x86_32, nor sparc (only aarch64 also has it presumably based on the x86_64 version). I think the time to factor this out would be if/when we do the code combining.
> 
> Thanks,
> David
> 
>> Thanks,
>> Coleen
>> 
>>> On 8/25/15 2:07 AM, David Holmes wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8133646
>>> 
>>> webrev: http://cr.openjdk.java.net/~dholmes/8133646/webrev/
>>> 
>>> The error raised in this bug was not reproducible - it was only seen
>>> on one machine which was subsequently re-imaged to run Windows. A
>>> similar Solaris system did not reproduce the bug.
>>> 
>>> Rather than just close this as not-reproducible I want to push the
>>> enhanced diagnostics that Vladimir provided here:
>>> 
>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019667.html
>>> 
>>> 
>>> which I've added to the two chunks of code that perform this thread
>>> sanity check.
>>> 
>>> Thanks,
>>> David
>>