RFR 8078555(M): GC: implement ranges (optionally constraints) for those flags that have them missing
Kim Barrett
kim.barrett at oracle.com
Thu Aug 27 16:58:19 UTC 2015
On Aug 27, 2015, at 12:53 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>
> Sangheon,
>
> A general question. A constraint function such as
>
> 49 static Flag::Error ParallelGCThreadsAndCMSWorkQueueDrainThreshold(uint threads, uintx threshold, bool verbose) {
> 50 // CMSWorkQueueDrainThreshold is verified to be less than max_juint
> 51 if (UseConcMarkSweepGC && (threads > (uint)(max_jint / (uint)threshold))) {
> 52 CommandLineError::print(verbose,
> 53 "ParallelGCThreads (" UINT32_FORMAT ") or CMSWorkQueueDrainThreshold ("
> 54 UINTX_FORMAT ") is too large\n",
> 55 threads, threshold);
> 56 return Flag::VIOLATES_CONSTRAINT;
> 57 }
> 58 return Flag::SUCCESS;
> 59 }
>
> takes parameters that should only be ParallelGCThreads for "threads" and
> only CMSWorkQueueDrainThreshold for "threshold". Is that right?
Or the proposed new value for one or the other. Which is why they are arguments rather
just directly referring to the variables.
More information about the hotspot-dev
mailing list