RFR (XS) 8143615 compactHashtable.hpp includes oop.inline.hpp file
Stefan Karlsson
stefan.karlsson at oracle.com
Thu Dec 3 09:09:09 UTC 2015
Hi Ioi,
Thanks a lot for fixing this!
Would you mind swapping these lines around?:
#include "classfile/javaClasses.hpp"
+#include "classfile/compactHashtable.inline.hpp"
Except for that nit, this looks good.
As David says, we should get rid of the allocation.inline.hpp include as
well, but I think we could defer that to a separate patch (if you want to).
Thanks,
StefanK
On 2015-12-03 03:32, Ioi Lam wrote:
> Please review a very small fix:
>
> http://cr.openjdk.java.net/~iklam/8143615-compactHashtable-inline-hpp/
>
> Bug: compactHashtable.hpp includes oop.inline.hpp file
>
> https://bugs.openjdk.java.net/browse/JDK-8143615
>
> Summary of fix:
>
> + deleted the include of oop.inline.hpp from compactHashtable.hpp
> + moved all inlined functions that require oop.inline.hpp into a
> new file, compactHashtable.inline.hpp
>
> Tests:
>
> JPRT
>
> Thanks
> - Ioi
More information about the hotspot-dev
mailing list