RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

Paul Sandoz paul.sandoz at oracle.com
Fri Dec 4 12:57:37 UTC 2015


> On 3 Dec 2015, at 19:25, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> You give the tests various compilation options, the interesting bit of code is in the compiler (the native entries are trivial), and the most likely people to break it are in the compiler (duck!).   The runtime test SQE lead and myself and others (offline unfortunately) have said "no" to testng in the runtime tests.

Coleen, to better understand the HotSpot runtime team’s debugging process and requirements i am still curious about how you do stuff as discussed on the now separate test-related thread. I think it would be useful to continue that discussion.


>>   So yes, for all these reasons the tests belong in the compiler test directories.
> 
> We already have testng tests so go ahead and put them in test/compiler/unsafe/.  The compiler team is not afraid of the future!
> 

Onward then! :-) Thanks!

Updated:

  http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/webrev/ <http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/webrev/>
  http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/webrev/ <http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/webrev/>

Paul.



More information about the hotspot-dev mailing list