RFR(L): JDK-8046936 : JEP 270: Reserved Stack Areas for Critical Sections

[Lindenmaier, Goetz]

Hi Frederic, 

Coleen pointed me to your change, and I wanted to have a look
at it. It seems to require some ppc adaptions. 

Unfortunately it does not apply to my hs-rt repository.  Also, 
I can not find out the revision you built it against, as it is not a
changeset patch, i.e., a webrev built from a submitted change.

Could you please rebase the change to a more recent hs-rt repo?

And please don't push it before at least the macros are defined in the
globals_ppc.hpp file.  And I really would like to check whether it
at least builds.

Thanks and best regards,
  Goetz.


applying hotspot.patch
patching file src/cpu/aarch64/vm/globals_aarch64.hpp
Hunk #1 FAILED at 57
1 out of 1 hunks FAILED -- saving rejects to file src/cpu/aarch64/vm/globals_aarch64.hpp.rej
patching file src/cpu/sparc/vm/stubGenerator_sparc.cpp
Hunk #1 FAILED at 5322
1 out of 1 hunks FAILED -- saving rejects to file src/cpu/sparc/vm/stubGenerator_sparc.cpp.rej
patching file src/cpu/x86/vm/macroAssembler_x86.hpp
Hunk #1 FAILED at 0
1 out of 2 hunks FAILED -- saving rejects to file src/cpu/x86/vm/macroAssembler_x86.hpp.rej
unable to find 'src/cpu/x86/vm/templateInterpreter_x86_32.cpp' for patching
1 out of 1 hunks FAILED -- saving rejects to file src/cpu/x86/vm/templateInterpreter_x86_32.cpp.rej
unable to find 'src/cpu/x86/vm/templateInterpreter_x86_64.cpp' for patching
1 out of 1 hunks FAILED -- saving rejects to file src/cpu/x86/vm/templateInterpreter_x86_64.cpp.rej
patching file src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java
Hunk #1 FAILED at 0
Hunk #2 FAILED at 151
2 out of 2 hunks FAILED -- saving rejects to file src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java.rej
patching file src/os/solaris/vm/os_solaris.hpp
Hunk #1 FAILED at 0
1 out of 2 hunks FAILED -- saving rejects to file src/os/solaris/vm/os_solaris.hpp.rej
patching file src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
Hunk #1 FAILED at 0
1 out of 4 hunks FAILED -- saving rejects to file src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp.rej
patching file src/share/vm/c1/c1_Compilation.hpp
Hunk #1 FAILED at 0
1 out of 3 hunks FAILED -- saving rejects to file src/share/vm/c1/c1_Compilation.hpp.rej
patching file src/share/vm/classfile/classFileParser.cpp
Hunk #1 FAILED at 1767
1 out of 2 hunks FAILED -- saving rejects to file src/share/vm/classfile/classFileParser.cpp.rej
patching file src/share/vm/classfile/classFileParser.hpp
Hunk #1 succeeded at 135 with fuzz 2 (offset 0 lines).
patching file src/share/vm/classfile/vmSymbols.hpp
Hunk #1 FAILED at 203
1 out of 1 hunks FAILED -- saving rejects to file src/share/vm/classfile/vmSymbols.hpp.rej
patching file src/share/vm/opto/compile.cpp
Hunk #1 succeeded at 674 with fuzz 2 (offset 1 lines).
patching file src/share/vm/runtime/thread.inline.hpp
Hunk #1 FAILED at 0
1 out of 3 hunks FAILED -- saving rejects to file src/share/vm/runtime/thread.inline.hpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh hotspot.patch


> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> Behalf Of Frederic Parain
> Sent: Donnerstag, 5. November 2015 15:17
> To: hotspot-dev at openjdk.java.net
> Subject: RFR(L): JDK-8046936 : JEP 270: Reserved Stack Areas for Critical
> Sections
> 
> Please review the changesets for JEP 270: Reserved Stack Areas for
> Critical Sections
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8046936
> 
> Webrevs:
>    hotspot: http://cr.openjdk.java.net/~fparain/8046936/webrev.00/hotspot/
>    JDK: http://cr.openjdk.java.net/~fparain/8046936/webrev.00/jdk/
> 
> The CR contains a detailed description of the issue and the design
> of the solution as well as implementation details.
> 
> Tests:
> 
>      JPRT - hotspot & core
>      RBT - vm.quick
> 
> Thanks
> 
> Fred
> 
> --
> Frederic Parain - Oracle
> Grenoble Engineering Center - France
> Phone: +33 4 76 18 81 17
> Email: Frederic.Parain at oracle.com