RFR(XS) 8145027: Exclude NUMAInterleaveGranularity from TestOptionsWithRanges.java

sangheon.kim sangheon.kim at oracle.com
Wed Dec 9 19:37:15 UTC 2015


Hi Jesper,

Thank you for the review!

Sangheon


On 12/09/2015 11:22 AM, Jesper Wilhelmsson wrote:
> Looks good!
> /Jesper
>
> Den 9/12/15 kl. 20:11, skrev sangheon.kim:
>> Hi all,
>>
>> Could I get some reviews to exclude 'NUMAInterleaveGranularity' from
>> TestOptionsWithRanges.java?
>>
>> Recent patch for JDK-8142341 includes an implementation of 
>> range/constraint for
>> NUMAInterleaveGranularity and this change enabled to test the flag by
>> TestOptionsWithRanges.java. And this test found 2 bugs (JDK-8144949 and
>> JDK-8145000) which are now integration blocker.
>>
>> JDK-8144949 occurs only under specific case(32bit binary + server 
>> mode) and
>> allocation related routine is not safe.
>> JDK-8145000 happened with valid value and I suspect that allocation 
>> related
>> routine is not safe.
>> JDK-8142341 has many other flags implemented.
>>
>> In this regard, I hope to exclude the flag from the test rather than 
>> back out
>> JDK-8142341.
>> And I will include this flag when I have stable range/constraint or 
>> related
>> routines enhanced.
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8145027
>> Webrev: http://cr.openjdk.java.net/~sangheki/8145027/webrev.00/
>>
>> Thanks,
>> Sangheon
>>
>>
>>



More information about the hotspot-dev mailing list