RFR (M): 8145435: [JVMCI] some tests on Windows fail with: assert(!thread->is_Java_thread()) failed: must not be java thread

Christian Thalinger christian.thalinger at oracle.com
Tue Dec 15 20:54:56 UTC 2015


https://bugs.openjdk.java.net/browse/JDK-8145435
http://cr.openjdk.java.net/~twisti/8145435/webrev/

The actual fix for the problem is passing true to os::sleep:

+  const bool interruptible = true;
+  os::sleep(THREAD, 200, interruptible);

since compiler threads are Java threads but I fixed a couple more things...

First, I’ve added the same assert to os_posix.cpp:

http://cr.openjdk.java.net/~twisti/8145435/webrev/src/os/posix/vm/os_posix.cpp.udiff.html

because it’s odd to only hit this assert on Windows:

Additionally I’ve changed the way we handle an exception in before_exit:

http://cr.openjdk.java.net/~twisti/8145435/webrev/src/share/vm/runtime/java.cpp.udiff.html

and moved abort_on_pending_exception into JVMCICompiler and made it private.  It’s used for one thing only now.

Finally I replaced JVMCIRuntime::call_printStackTrace with calls to java_lang_Throwable::print_stack_trace.


More information about the hotspot-dev mailing list