RFR(S): 8145400 - ProjectCreator broken after JEP 223 changes

[Markus Gronlund]

Hi Christian,

Thanks for taking this on. 

Could you please retain the build targets please? I use debug C2 on my win32 laptop as a matter of course. 

There is no need to limit the amount of build targets, it allows for flexibility.

Thanks
Markus


-----Original Message-----
From: Christian Tornqvist 
Sent: den 16 december 2015 18:28
To: hotspot-dev at openjdk.java.net
Subject: RFR(S): 8145400 - ProjectCreator broken after JEP 223 changes

Hi everyone,

 

Please review this change that updates ProjectCreator to work with the new version string change in JEP 223. Tested the change locally, had to use a workaround for the issue described in JDK-8144716. 

Also cleaned up some old build targets that are not needed anymore.

 

This is how the version string looks like when building in VS:

Debug:

Java HotSpot(TM) 64-Bit Server VM (debug build
9-internal+0.christian.vsbuild-debug, mixed mode)

Fastdebug:

Java HotSpot(TM) 64-Bit Server VM (fastdebug build
9-internal+0.christian.vsbuild-fastdebug, mixed mode)

Product:

Java HotSpot(TM) 64-Bit Server VM (product build
9-internal+0.christian.vsbuild, mixed mode)

 

Using make system

Fastdebug:

Java HotSpot(TM) 64-Bit Server VM (fastdebug build
9-internal+0-2015-12-16-120539.christian.jdk9-rt, mixed mode)

 

Webrev:

http://cr.openjdk.java.net/~ctornqvi/webrev/8145400/webrev.00/

Bug:

https://bugs.openjdk.java.net/browse/JDK-8145400

 

Thanks,

Christian