RFR(S): 8145603 - Enable build.bat to use vcproj to build

[Christian Tornqvist]

Hi Mikael,


Thanks for the review, added a comment. Please see the updated webrev at:
http://cr.openjdk.java.net/~ctornqvi/webrev/8145603/webrev.01/make/windows/b
uild.bat.sdiff.html

Thanks,
Christian

-----Original Message-----
From: Mikael Vidstedt [mailto:mikael.vidstedt at oracle.com] 
Sent: Wednesday, December 16, 2015 6:07 PM
To: Christian Tornqvist <christian.tornqvist at oracle.com>;
hotspot-dev at openjdk.java.net
Subject: Re: RFR(S): 8145603 - Enable build.bat to use vcproj to build




On 2015-12-16 14:48, Christian Tornqvist wrote:
> Hi everyone,
>
>   
>
> Build.bat has not been working correctly for a couple of years and is 
> now completely broken after the JDK Version change. Rewrote it to use 
> the Visual Studio project files instead, examples of use:
>
>   
>
> make\windows\build.bat tiered fastdebug
>
>   
>
> This will generate the vcproj files using create.bat (if they haven't 
> been generated before) and compile the JVM using msbuild. The whole 
> process takes about a minute on my machine and less than that if the 
> vcproj files are already there.
>
>   
>
> Tested locally with x86 and x64 builds.
>
>   
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8145603/webrev.00/
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8145603

Not being fluent in .bat I could use a helpful comment on what line 26 (set
HotSpotWorkSpace) actually does.

Apart from that it looks good!

Cheers,
Mikael