RFR (M): 8145435: [JVMCI] some tests on Windows fail with: assert(!thread->is_Java_thread()) failed: must not be java thread
Doug Simon
doug.simon at oracle.com
Thu Dec 17 13:56:45 UTC 2015
> On 17 Dec 2015, at 08:20, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
>
>>>>
>>>> I feel like there was a reason we weren’t using java_lang_Throwable::print_stack_trace but it looks like it handles the causes properly which is the only reason I could think of. Maybe Doug knows?
>>>
>>>
>>> There are two issues with java_lang_Throwable::print_stack_trace:
>>>
>>> 1. It doesn’t print the exception message, just the stack.
>>
>> I’m printing the message separately:
>>
>> java_lang_Throwable::print(exception, tty);
>> tty->cr();
>> java_lang_Throwable::print_stack_trace(exception(), tty);
>
> There are already 3 other copies of this idiom. Throwable should probably have a single method for this. Or maybe print_stack_trace itself should do this?
+1
> That would better parallel Throwable.printStackTrace().
Makes sense to me!
-Doug
More information about the hotspot-dev
mailing list