RFR(S): 8145400 - ProjectCreator broken after JEP 223 changes

[Lois Foltan]

I think the latest webrev looks good.  Thanks for doing this Christian!
Lois

On 12/17/2015 7:08 AM, Christian Tornqvist wrote:
> Hi Magnus,
>
> Good catch, didn't read the version string as closely as I thought I did.
> I changed the opt part to not include the debug_level either, now the
> version string looks like this:
>
> Java HotSpot(TM) 64-Bit Client VM (fastdebug build
> 9-internal+0-christian.vsbuild, mixed mode)
>
> Please see the new webrev at:
> http://cr.openjdk.java.net/~ctornqvi/webrev/8145400/webrev.01/
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: Magnus Ihse Bursie [mailto:magnus.ihse.bursie at oracle.com]
> Sent: Thursday, December 17, 2015 3:23 AM
> To: Christian Tornqvist <christian.tornqvist at oracle.com>;
> hotspot-dev at openjdk.java.net
> Subject: Re: RFR(S): 8145400 - ProjectCreator broken after JEP 223 changes
>
> On 2015-12-16 18:28, Christian Tornqvist wrote:
>> Hi everyone,
>>
>>    
>>
>> Please review this change that updates ProjectCreator to work with the
>> new version string change in JEP 223. Tested the change locally, had
>> to use a workaround for the issue described in JDK-8144716.
>>
>> Also cleaned up some old build targets that are not needed anymore.
>>
>>    
>>
>> This is how the version string looks like when building in VS:
>>
>> Debug:
>>
>> Java HotSpot(TM) 64-Bit Server VM (debug build
>> 9-internal+0.christian.vsbuild-debug, mixed mode)
> That does not look like a valid version string.
> '9-internal+0-.christian.vsbuild-debug' would be valid but strange-looking,
> '9-internal+0-christian.vsbuild-debug' would probably be better. Also note
> that the "opt" part of the version string does not contain "debug" any more
> in make builds. (But you are of course free to add anything to the opt
> string.)
>
> /Magnus
>
>> Fastdebug:
>>
>> Java HotSpot(TM) 64-Bit Server VM (fastdebug build
>> 9-internal+0.christian.vsbuild-fastdebug, mixed mode)
>>
>> Product:
>>
>> Java HotSpot(TM) 64-Bit Server VM (product build
>> 9-internal+0.christian.vsbuild, mixed mode)
>>
>>    
>>
>> Using make system
>>
>> Fastdebug:
>>
>> Java HotSpot(TM) 64-Bit Server VM (fastdebug build
>> 9-internal+0-2015-12-16-120539.christian.jdk9-rt, mixed mode)
>>
>>    
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8145400/webrev.00/
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8145400
>>
>>    
>>
>> Thanks,
>>
>> Christian
>>
>