RFR (s) : 8145740: Visual Studio pragmas should be guarded by #ifdef _MSC_VER
Baesken, Matthias
matthias.baesken at sap.com
Fri Dec 18 13:29:52 UTC 2015
Hello,
can you please review and sponsor this change :
https://bugs.openjdk.java.net/browse/JDK-8145740
http://cr.openjdk.java.net/~clanger/webrevs/8145740.0/
Some details :
while Visual Studio pragmas in shared code are usually guarded with _MSC_VER in the hotspot codebase
( see for example taskqueue.hpp or compressedStream.cpp ) , the guarding is missing in src/share/vm/utilities/growableArray.hpp ,
which is not really a "good thing" for other compilers .
Thanks and regards, Matthias
More information about the hotspot-dev
mailing list