RFR (XXS): 8146043: run JVMCI tests in JPRT

Gary Collins gary.collins at oracle.com
Wed Dec 23 23:43:28 UTC 2015 

Looks good.. Thanks for the Data.

The reason I asked about the differences is related to all the performance bugs about job times in the
JPRT queue.  A small change like this one is GREAT to help with coverage yet will impact the overall job
completion time as a whole.  Keep adding tests, this is what the tool is designed to do. Helps ensure we 
have solid set of bits.

Cumulative changes overtime will add up. With the perception something is wrong with the JPRT.  

Cheers,
Gary



> On Dec 23, 2015, at 3:22 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
> 
>> On Dec 23, 2015, at 1:12 PM, Gary Collins <gary.collins at oracle.com <mailto:gary.collins at oracle.com>> wrote:
>> 
>> Thanks, 
>> 
>> What was the before and after for each plat?  Do you have the data?
> 
> Sure.  Any successful JPRT should do:
> 
>   linux_i586_2.6-fastdebug-c1-hotspot_compiler_1     success(19m 58s)
>   linux_i586_2.6-fastdebug-c1-hotspot_compiler_2     success(04m 49s)
>   linux_i586_2.6-fastdebug-c1-hotspot_compiler_3     success(09m 45s)
>   linux_i586_2.6-fastdebug-c1-hotspot_compiler_closed     success(04m 00s)
>   linux_i586_2.6-fastdebug-c2-hotspot_compiler_1     success(04m 02s)
>   linux_i586_2.6-fastdebug-c2-hotspot_compiler_2     success(04m 59s)
>   linux_i586_2.6-fastdebug-c2-hotspot_compiler_3     success(07m 38s)
>   linux_i586_2.6-fastdebug-c2-hotspot_compiler_closed     success(06m 06s)
>   linux_x64_2.6-fastdebug-c2-hotspot_compiler_1     success(03m 26s)
>   linux_x64_2.6-fastdebug-c2-hotspot_compiler_2     success(16m 14s)
>   linux_x64_2.6-fastdebug-c2-hotspot_compiler_3     success(40m 09s)
>   linux_x64_2.6-fastdebug-c2-hotspot_compiler_closed     success(03m 40s)
>   macosx_x64_10.9-fastdebug-c2-hotspot_compiler_1     success(07m 02s)
>   macosx_x64_10.9-fastdebug-c2-hotspot_compiler_2     success(05m 09s)
>   macosx_x64_10.9-fastdebug-c2-hotspot_compiler_3     success(22m 46s)
>   macosx_x64_10.9-fastdebug-c2-hotspot_compiler_closed     success(10m 38s)
>   solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_1     success(12m 40s)
>   solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_2     success(15m 53s)
>   solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_3     success(49m 52s)
>   solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_closed     success(16m 35s)
>   solaris_x64_5.11-fastdebug-c2-hotspot_compiler_1     success(04m 24s)
>   solaris_x64_5.11-fastdebug-c2-hotspot_compiler_2     success(05m 25s)
>   solaris_x64_5.11-fastdebug-c2-hotspot_compiler_3     success(10m 48s)
>   solaris_x64_5.11-fastdebug-c2-hotspot_compiler_closed     success(04m 47s)
>   windows_i586_6.2-fastdebug-c1-hotspot_compiler_1     success(11m 04s)
>   windows_i586_6.2-fastdebug-c1-hotspot_compiler_2     success(09m 52s)
>   windows_i586_6.2-fastdebug-c1-hotspot_compiler_3     success(16m 37s)
>   windows_i586_6.2-fastdebug-c1-hotspot_compiler_closed     success(18m 32s)
>   windows_i586_6.2-fastdebug-c2-hotspot_compiler_1     success(09m 43s)
>   windows_i586_6.2-fastdebug-c2-hotspot_compiler_2     success(09m 53s)
>   windows_i586_6.2-fastdebug-c2-hotspot_compiler_3     success(22m 19s)
>   windows_i586_6.2-fastdebug-c2-hotspot_compiler_closed     success(15m 34s)
>   windows_x64_6.2-fastdebug-c2-hotspot_compiler_1     success(11m 19s)
>   windows_x64_6.2-fastdebug-c2-hotspot_compiler_2     success(10m 33s)
>   windows_x64_6.2-fastdebug-c2-hotspot_compiler_3     success(17m 12s)
>   windows_x64_6.2-fastdebug-c2-hotspot_compiler_closed     success(14m 40s)
> 
>> 
>> With your change what is the before or rather the delta change?
>> solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_3 success(26m 28s) 
> 
> I’ve added the tests to hotspot_compiler_2 so this one shouldn’t be relevant.
> 
>> 
>> 
>>  
>> 
>>> On Dec 23, 2015, at 2:53 PM, Christian Thalinger <christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>> wrote:
>>> 
>>> 
>>>> On Dec 23, 2015, at 12:36 PM, Gary Collins <gary.collins at oracle.com <mailto:gary.collins at oracle.com>> wrote:
>>>> 
>>>> What are the number for all platforms?
>>> 
>>> Look at the numbers in the bug.
>>> 
>>>> I believe this is  what DavidH is looking for.. We are looking to optimize the JPRT machines.
>>>> Having an understanding of this change for all plats would be helpful before we push.
>>>> 
>>>> Thanks
>>>> Gary
>>>>> On Dec 23, 2015, at 2:27 PM, Christian Tornqvist <christian.tornqvist at oracle.com <mailto:christian.tornqvist at oracle.com>> wrote:
>>>>> 
>>>>> Yes, looked at the JPRT logs as well, the JVMCI tests seems quick enough to
>>>>> run in JPRT.
>>>>> 
>>>>> Thanks,
>>>>> Christian
>>>>> 
>>>>> -----Original Message-----
>>>>> From: Christian Thalinger [mailto:christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>] 
>>>>> Sent: Wednesday, December 23, 2015 5:16 PM
>>>>> To: Christian Tornqvist <christian.tornqvist at oracle.com <mailto:christian.tornqvist at oracle.com>>
>>>>> Cc: hotspot-dev developers <hotspot-dev at openjdk.java.net <mailto:hotspot-dev at openjdk.java.net>>
>>>>> Subject: Re: RFR (XXS): 8146043: run JVMCI tests in JPRT
>>>>> 
>>>>> David Holmes said he wanted a JPRT run to see the impact.  Did you look at
>>>>> the times I put in the bug?
>>>>> 
>>>>>> On Dec 23, 2015, at 2:11 AM, Christian Tornqvist
>>>>> <christian.tornqvist at oracle.com <mailto:christian.tornqvist at oracle.com>> wrote:
>>>>>> 
>>>>>> Hi Chris,
>>>>>> 
>>>>>> This looks good.
>>>>>> 
>>>>>> Thanks,
>>>>>> Christian
>>>>>> 
>>>>>> -----Original Message-----
>>>>>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net <mailto:hotspot-dev-bounces at openjdk.java.net>] On 
>>>>>> Behalf Of Christian Thalinger
>>>>>> Sent: Tuesday, December 22, 2015 6:07 PM
>>>>>> To: hotspot-dev developers <hotspot-dev at openjdk.java.net <mailto:hotspot-dev at openjdk.java.net>>
>>>>>> Subject: RFR (XXS): 8146043: run JVMCI tests in JPRT
>>>>>> 
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8146043 <https://bugs.openjdk.java.net/browse/JDK-8146043>
>>>>>> 
>>>>>> Running all JVMCI tests on my MacBook takes about 2 minutes:
>>>>>> 
>>>>>> Test results: passed: 63; error: 3
>>>>>> Results written to /private/tmp/twisti
>>>>>> Error: Some tests failed or other problems occurred.
>>>>>> 
>>>>>> real	2m6.236s
>>>>>> user	4m7.922s
>>>>>> sys	0m14.363s
>>>>>> 
>>>>>> Looking at a few JPRT jobs it seems hotspot_compiler_2 takes the least 
>>>>>> amount of time currently.
>>>>>> 
>>>>>> diff -r 46122d93612d test/TEST.groups
>>>>>> --- a/test/TEST.groups	Mon Dec 21 22:17:23 2015 +0100
>>>>>> +++ b/test/TEST.groups	Tue Dec 22 13:02:47 2015 -1000
>>>>>> @@ -279,6 +279,7 @@ hotspot_compiler_2 = \
>>>>>> compiler/inlining/ \
>>>>>> compiler/integerArithmetic/ \
>>>>>> compiler/interpreter/ \
>>>>>> +  compiler/jvmci/ \
>>>>>> -compiler/codegen/7184394 \
>>>>>> -compiler/codecache/stress
>>>>>> 
>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>> 
>>> 
>> 
>

More information about the hotspot-dev mailing list