RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

Volker Simonis volker.simonis at gmail.com
Thu Feb 12 09:13:15 UTC 2015


What's the general opinion - shouldn't we add a check for missing
newlines at the end of a file to jcheck?

Who could do that?

Regards,
Volker


On Thu, Feb 12, 2015 at 9:09 AM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> On Wed, Feb 11, 2015 at 9:49 PM, Dean Long <dean.long at oracle.com> wrote:
>
>> It looks like you replaced } with }\n\n where }\n would have been enough,
>> but no harm done.
>>
>> dl
>>
>>
> webrev.sh produced an empty change ("0 lines modified") when I added a
> single linefeed. That's why I added two.
>
> Thomas
>
>
>>
>> On 2/11/2015 8:37 AM, Thomas Stüfe wrote:
>>
>>> Hi,
>>>
>>> Linux build did break after 8067447, please review this tiny fix:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8072935
>>> http://cr.openjdk.java.net/~stuefe/webrevs/8072935/webrev.01/webrev/
>>>
>>> Thank you!
>>>
>>> Kind Regards, Thomas
>>>
>>
>>


More information about the hotspot-dev mailing list