RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

David Holmes david.holmes at oracle.com
Thu Feb 12 11:53:48 UTC 2015


On 12/02/2015 5:28 PM, Thomas Stüfe wrote:
>
> On Thu, Feb 12, 2015 at 12:55 AM, David Holmes <david.holmes at oracle.com
> <mailto:david.holmes at oracle.com>> wrote:
>
>     On 12/02/2015 2:37 AM, Thomas Stüfe wrote:
>
>         Hi,
>
>         Linux build did break after 8067447, please review this tiny fix:
>
>
>     Howe did this break any build? The change should have been pushed
>     via JPRT and so was built on a number of linux platforms! ??
>
>
> Hi David,
>
> Older version of g++ warn about missing newlines. Error happens with g++
> 4.1.2.

Ah I see.

> This compiler may be too old, but then I would have expected configure
> to fail when checking the build prerequisites.

Yeah not sure we have a minimum gcc version set - but we probably 
should! Something for the build folk - I'll forward this over to build-dev.

Thanks,
David

> Regards, Thomas
>
>
>     Thanks,
>     David
>
>
>         https://bugs.openjdk.java.net/__browse/JDK-8072935
>         <https://bugs.openjdk.java.net/browse/JDK-8072935>
>         http://cr.openjdk.java.net/~__stuefe/webrevs/8072935/webrev.__01/webrev/
>         <http://cr.openjdk.java.net/~stuefe/webrevs/8072935/webrev.01/webrev/>
>
>         Thank you!
>
>         Kind Regards, Thomas
>
>


More information about the hotspot-dev mailing list