RFR: 8073389: Remove the include of resourceArea.hpp from classFileParser.hpp
Stefan Karlsson
stefan.karlsson at oracle.com
Wed Feb 18 15:54:14 UTC 2015
On 2015-02-18 14:20, Coleen Phillimore wrote:
>
> Seems good.
Thanks,
StefanK
>
> Coleen
>
> On 2/18/15, 4:35 AM, Stefan Karlsson wrote:
>> Hi,
>>
>> Please review this patch to get rid of the inclusion of
>> resourceArea.hpp from classFileParser.hpp.
>>
>> From the RFE:
>>
>> The inclusion of resourceArea.hpp in classFileParser.hpp is causing
>> cyclic dependencies when I'm changing unrelated code. The main reason
>> for this is that a lot of implementation is put inside the
>> resourceArea.hpp file instead of a .cpp file.
>>
>> I've opted to go the easy route now and get rid of the the
>> resourceArea.hpp dependency from classFileParser.hpp, but eventually
>> it would be good to fix that file.
>>
>> This patch has to add explicit includes of resourceArea.hpp to other
>> .hpp files, that used to get their include from classFileParser.hpp.
>> I could have gotten rid of those dependencies as well, but I chose to
>> not do that for this patch.
>>
>> http://cr.openjdk.java.net/~stefank/8073389/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8073389
>>
>> Thanks,
>> StefanK
>
More information about the hotspot-dev
mailing list