RFR: 8073387: Move VerifyOopClosures out from genOopClosures.hpp
Coleen Phillimore
coleen.phillimore at oracle.com
Wed Feb 18 16:36:25 UTC 2015
It's a minor comment so I don't need to see another webrev.
thanks!
Coleen
On 2/18/15, 11:04 AM, Stefan Karlsson wrote:
> On 2015-02-18 14:17, Coleen Phillimore wrote:
>>
>> I have a request - can you name the file verifyOopClosure.hpp There's
>> a different JVM option that we use that is -XX:+VerifyOops which is
>> completely different than this. The name of the class in
>> verifyOop.hpp is VerifyOopClosure also.
>
> Sure.
>
> StefanK
>
>>
>> Coleen
>>
>> On 2/18/15, 3:25 AM, Mikael Gerdin wrote:
>>> Hi Stefan,
>>>
>>> On 2015-02-18 09:10, Stefan Karlsson wrote:
>>>> Hi,
>>>>
>>>> Please review this patch to move VerifyOopClosures out from
>>>> genOopClosures.hpp. This way users of VerifyOopClosures don't have to
>>>> include genOopClosures.hpp anymore. The implementation of
>>>> VerifyOopClosures::do_oop_work is placed in oop.cpp, where the other
>>>> VerifyOopClosure functions are located.
>>>>
>>>> http://cr.openjdk.java.net/~stefank/8073387/webrev.01/
>>>
>>> Looks good to me.
>>>
>>> /Mikael
>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8073387
>>>>
>>>> Thanks,
>>>> StefanK
>>>
>>
>
More information about the hotspot-dev
mailing list