RFR(M) 8072383: resolve conflicts between open and closed ports

Volker Simonis volker.simonis at gmail.com
Fri Feb 20 13:51:16 UTC 2015


The 9 patch is against http://hg.openjdk.java.net/aarch64-port/stage

On Fri, Feb 20, 2015 at 2:37 PM, Severin Gehwolf <sgehwolf at redhat.com> wrote:
> On Thu, 2015-02-19 at 16:44 +0100, Severin Gehwolf wrote:
>> On Wed, 2015-02-18 at 20:12 -0800, Dean Long wrote:
>> > Yes, good catch.  I've update the webrev to webrev.8u60.01.  Thanks for
>> > the review.
>>
>> Has anyone tested those changes with a Zero build
>> (--with-jvm-variants=zero)? Specifically on arm/ppc? I'm testing it now
>> and get back to you.
>
> Disclaimer: Not a reviewer.
>
> I've only tested the 8 webrev. It seems to be fine for Zero on
> arm/ppc/x86_64. Thumbs up from me.
>
> FWIW, the 9 patch didn't apply for me. Not sure which forest you were
> using. I was trying jdk9/hs-comp.
>
> Cheers,
> Severin
>
>> Thanks,
>> Severin
>>
>> > dl
>> >
>> > On 2/18/2015 4:45 PM, Vladimir Kozlov wrote:
>> > > Did you missed to remove #elif ppc_32 in 8u60 changes in
>> > > src/share/vm/interpreter/templateTable.hpp?
>> > >
>> > > Otherwise both versions look good.
>> > >
>> > > Thanks,
>> > > Vlaidmir
>> > >
>> > > On 2/18/15 4:26 PM, Dean Long wrote:
>> > >> Just to avoid confusion, let me clarify that the jdk9 changes below
>> > >> can't be pushed until after the open aarch64 port is merged into the
>> > >> main jdk9, as they are based on the staging repo.
>> > >>
>> > >> dl
>> > >>
>> > >> On 2/18/2015 4:02 PM, Dean Long wrote:
>> > >>> These changes resolve some issues with references to closed ports in
>> > >>> open hotspot code,
>> > >>> primarily by removing those references completely.  I have included
>> > >>> the 8u60 backport
>> > >>> as well because it won't apply cleanly, and I may push it first
>> > >>> because the 9 changes are
>> > >>> blocked by JEP 237: Linux/AArch64 Port.
>> > >>>
>> > >>> http://cr.openjdk.java.net/~dlong/8072383/webrev.8u60.00/
>> > >>> http://cr.openjdk.java.net/~dlong/8072383/webrev.9.00/
>> > >>>
>> > >>> dl
>> > >>
>> >
>>
>>
>>
>
>
>


More information about the hotspot-dev mailing list