RFR(M): 8073315: Enable gcc -Wtype-limits and fix upcoming issues.

[Lindenmaier, Goetz]

Hi Kim,

that's OK, take your time.  I'll eventually ping again.  There is no hurry with this.

Jep, that's the fix to gcc one wants to have.  
I'm fine with enabling the warning only for gcc 4.8. That's the 
version Oracle is using for the jprt build, right?

Best regards,
  Goetz.


-----Original Message-----
From: Kim Barrett [mailto:kim.barrett at oracle.com] 
Sent: Mittwoch, 25. Februar 2015 21:36
To: Lindenmaier, Goetz
Cc: hotspot-dev Source Developers
Subject: Re: RFR(M): 8073315: Enable gcc -Wtype-limits and fix upcoming issues.

On Feb 25, 2015, at 5:52 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
> 
> Hi Kim,
> 
> Do you have any more comments on this?

Sorry for the delay.  I do, but am swamped with other things just now.  I hope to get back to this for real in the next couple of days.

Short answer is that I'm fine with most of the changes, except the warning enable.  However, it appears the relevant gcc bug was fixed in gcc4.8 (not sure which patch version):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=11856

[Note there are quite a few duplicates of that bug too; roughly 10 in total.]

If the warning were enabled conditionally on the gcc version, that would satisfy me.