8068054: AARCH64: Assembler interpreter, shared runtime

Coleen Phillimore coleen.phillimore at oracle.com
Fri Jan 2 19:01:10 UTC 2015


On 1/2/15, 1:45 PM, Andrew Haley wrote:
> Hi,
>
> On 01/02/2015 06:30 PM, Coleen Phillimore wrote:
>> Hi Andrew, I had a short look at this code and spot-checked some
>> functions in the interpreter.  In all these files, were any of the
>> functions added in a different place than in the x86 ports or is this
>> consistent with the other ports?
> Gosh.  I had no idea that consistency with any other port would be any
> kind of an issue; I never even considered the question, but it's
> similar to x86.

The reason I asked is that if I have to add something to one platform, 
it would be nice to find it in the same place for another, that's all.
>
>> +// Method entry for java.lang.ref.Reference.get.
>> +address InterpreterGenerator::generate_Reference_get_entry(void) {
>> +  return NULL;
>> +}
>>
>> Why isn't this implemented? I think this needs to have code to support
>> the G1 garbage collector.  I don't know this architecture, but I think
>> you can use my code review nonetheless.
> Okay.  I think G1 works, but I don't know about this issue.  I'll have
> a look.

You may not need this code; it may be an optimization.  The hg history 
and bug number it points to would say.

Coleen

> Thanks,
> Andrew.



More information about the hotspot-dev mailing list