RFR (S): 8068026: [TESTBUG] Check for -client in gc/g1/TestHumongousCodeCacheRoots.java

[Jesper Wilhelmsson]

Looks good!

In the future I would prefer if you upload a new webrev with a new URL instead 
of updating the existing webrev also for small changes like this one.

Thanks!
/Jesper


Lindenmaier, Goetz skrev den 5/1/15 12:48:
> Hi,
>
> I fixed it as proposed.
> http://cr.openjdk.java.net/~goetz/webrevs/8068026-jtregClient/webrev.01/
>
> I also assured the right exception is thrown, if I change the check for
> the exit value to check for '1' (so that I get a test error), I now get:
>    java.lang.RuntimeException: Expected to get exit value of [1]
> while before, it would have said the wrong message:
>     java.lang.RuntimeException: 'Unrecognized option: -client' missing from stdout/stderr
>
> Best regards,
>    Goetz.
>
>
> -----Original Message-----
> From: Jesper Wilhelmsson [mailto:jesper.wilhelmsson at oracle.com]
> Sent: Montag, 5. Januar 2015 11:03
> To: Lindenmaier, Goetz; 'hotspot-dev at openjdk.java.net'
> Subject: Re: RFR (S): 8068026: [TESTBUG] Check for -client in gc/g1/TestHumongousCodeCacheRoots.java
>
> Hi,
>
> It seems your change introduces dead code:
>
> +        if (output.shouldContain("Unrecognized option: -client") == null) {
> +            throw e;
> +        }
>
> If the string is found shouldContain will return a reference to 'output' (!=
> null), and if the string is not found it will throw an exception, so the
> introduced throw will never happen, right?
>
> This means the original exception 'e' is lost and a different one is thrown if
> -client was accepted by the VM.
>
> /Jesper
>
>
> Lindenmaier, Goetz skrev den 5/1/15 10:38:
>> Just a little reminder ... this is really small!
>>
>> From: Lindenmaier, Goetz
>> Sent: Montag, 22. Dezember 2014 14:08
>> To: 'hotspot-dev at openjdk.java.net'
>> Subject: RFR (S): 8068026: [TESTBUG] Check for -client in gc/g1/TestHumongousCodeCacheRoots.java
>>
>> Hi,
>>
>> I please need a review and a sponsor for this tiny change:
>>
>> http://cr.openjdk.java.net/~goetz/webrevs/8068026-jtregClient/webrev.01/
>> The test did not check whether -client is supported.
>>
>> The patch should also go to 8u60, please.
>>
>> Best regards,
>>     Goetz
>>