8068053: AARCH64: C1 and C2 compilers

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Jan 5 19:59:27 UTC 2015


On 1/5/15 10:12 AM, Andrew Haley wrote:
> On 01/05/2015 05:50 PM, Roland Westrelin wrote:
>> Hi Andrew,
>>
>>> http://cr.openjdk.java.net/~aph/aarch64-8068053-2/

Looks good.

>>
>> Shouldn’t c1_FpuStackSim_aarch64.[ch]pp be empty like it is on sparc?
>
> Oh yes, that's a hangover from x86.  Will remove.  How embarrassing.   :-)
>
>> What's ad_encode.m4 for?
>
> The encode patterns in aarch64.ad are very repetitive, so I used m4 to generate
> them.

Could you explain how you process it? I don't see aarch64_enc_strw_immn() in .ad file. And I don't remember changes in 
makefiles which use it.

And it is missing Copyright header.

Thanks,
Vladimir

>
>> Typo:
>> 831 // advance declaratuons for helper functions to convert register
>
> OK.
>
>> in aarch64.ad
>>
>> That looks good to me.
>
> Thanks,
> Andrew.
>
>


More information about the hotspot-dev mailing list