RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests

[Filipp]

Hi Goetz,

Looks good to me.

Thanks,
Filipp.

-----Исходное сообщение-----
От: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
Отправлено: ‎07.‎01.‎2015 17:49
Кому: "Filipp " <filipp.zhinkin at gmail.com>; "'hotspot-dev at openjdk.java.net'" <hotspot-dev at openjdk.java.net>
Тема: RE: RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests

Hi Filipp
 
I fixed TestMutuallyExclusivePlatformPredicates.java and uploaded a new webrev:
http://cr.openjdk.java.net/~goetz/webrevs/8068013-jtregAix/webrev-02/
 
Thank you for pointing me to that.  Somehow it’s not run in our nightly tests.
 
I also fixed the copyrights.
 
Best regards,
  Goetz.
 
From: Filipp [mailto:filipp.zhinkin at gmail.com] 
Sent: Mittwoch, 7. Januar 2015 14:10
To: Lindenmaier, Goetz; 'hotspot-dev at openjdk.java.net'
Subject: RE: RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests
 
Hi Goetz,

you have to update TestMutuallyExclusivePlatformPredicates test [1], because you've added mutually exclusive predicate. Otherwise that test will fail.

Also, I'd prefer to see switch instead of if-else chain in DynLibDcmdTest, but I'm fine with leaving it as it is now.

Otherwise change looks good.

Regards,
Filipp.

[1] http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/acfdd92cedaa/test/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java#l48



От: Lindenmaier, Goetz
Отправлено: ‎07.‎01.‎2015 14:03
Кому: 'hotspot-dev at openjdk.java.net'
Тема: RE: RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests
Hi,

my first upload missed the fix in Platform.shouldSAAttach():

+        if (isAix()) {
+            return false;   // SA not implemented.

I added that to the webrev.

Sorry,
  Goetz


From: Lindenmaier, Goetz
Sent: Mittwoch, 7. Januar 2015 11:14
To: 'hotspot-dev at openjdk.java.net'
Subject: RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests

Hi,

A row of hotspot jtreg tests fail because support to test for Aix is missing.
To pass them, I would like to submit the following fixes:

* runtime/6888954/vmerrors.sh: AIX can read from address '0', then throws SIGILL.
* serviceability/dcmd/DynLibDcmdTest.java: Just add check for Aix.
* test/test_env.sh: Add support for AIX. Sort OSes alphabetical.
* test/testlibrary/com/oracle/java/testlibrary/Platform.java: add isAix(). Sort OSes alphabetical.

Please review this change, and I please need a sponsor.
http://cr.openjdk.java.net/~goetz/webrevs/8068013-jtregAix/webrev-01/

Thanks and best regards,
  Goetz.