RFR(M): 8068503: ppc64: Encode/Decode nodes for disjoint cOops mode

Volker Simonis volker.simonis at gmail.com
Wed Jan 14 13:42:55 UTC 2015


Hi Goetz,

the change looks good.
Thumbs up from my side.

Regards,
Volker


On Mon, Jan 12, 2015 at 8:57 AM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi Coleen,
>
> Now I implemented the optimization in macroAssembler, also for the
> decode case, anyways.
> Unfortunately it's only used in the methodHandles code.
> Testing took a bit because the results were spoiled by unrelated problems.
>
> I uploaded a new webrev:
> http://cr.openjdk.java.net/~goetz/webrevs/8068503-ppcDisjoint/webrev.02/
>
> Best regards,
>   Goetz.
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
> Sent: Wednesday, January 07, 2015 3:54 PM
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR(M): 8068503: ppc64: Encode/Decode nodes for disjoint cOops mode
>
>
> Don't you have to make (or want to make) changes to
> MacroAssembler::decode_heap_oop_not_null in the macro assembler files?
>
> Coleen
>
> On 1/7/15, 3:26 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> this change contains the implementation (activation) of the
>> encode/decode nodes exploiting the disjoint heap base
>> available since "8064457: Introduce compressed oops mode disjoint base..."
>>
>> Please review this change.
>> http://cr.openjdk.java.net/~goetz/webrevs/8068503-ppcDisjoint/
>>
>> This is ppc64-only, so I don't need a sponsor ;)
>>
>> Best regards,
>>    Goetz.
>>
>


More information about the hotspot-dev mailing list