RFR (S): 8068026: [TESTBUG] Check for -client in gc/g1/TestHumongousCodeCacheRoots.java

[Thomas Schatzl]

Hi Goetz,

On Mon, 2014-12-22 at 13:07 +0000, Lindenmaier, Goetz wrote:
> Hi,
> 
> I please need a review and a sponsor for this tiny change:
> 
> http://cr.openjdk.java.net/~goetz/webrevs/8068026-jtregClient/webrev.01/
> The test did not check whether -client is supported.
> 
> The patch should also go to 8u60, please.

  I think it would be cleaner to split the test into two tests, each
@require'ing the particular vm flavor. And having a @run tag using
-client/-server respectively.

E.g.

// client test:
@...
@requires vm.flavor == client
@run main -client TestHumongousCodeCacheRootsClient

class TestHumongousCodeCacheRootsClient {
  public static void main(String[] args) {
    TestHumongousCodeCacheRootsHelper.main(args); // put into an
auxiliary class file...
  }
}

// server test:
@...
@requires vm.flavor == client
@run main -client TestHumongousCodeCacheRootsServer

class TestHumongousCodeCacheRootsServer {
  public static void main(String[] args) {
    TestHumongousCodeCacheRootsHelper.main(args); // put into an
auxiliary class file...
  }
}

That *could* work, and avoid the dodgy exception catching.

Thanks,
  Thomas