RFR (S): 8068026: [TESTBUG] Check for -client in gc/g1/TestHumongousCodeCacheRoots.java

[Lindenmaier, Goetz]

Hi Thomas,

I also counted the VM used for compilation of the test.
If I understood right, each test is first compiled, then executed.
So for a VM with client and server it's 4 VM starts before (javac, 
test, 2xtestee), 6 after.  And I have the feeling that the compilation 
eats a lot of test time.

Setting up a shared helper class  simplifies fixing the test.  That's
good.

I've one change to go to fix the tests for ppc, then I'll address this
one, ok?

Best regards,
  Goetz.



-----Original Message-----
From: Thomas Schatzl [mailto:thomas.schatzl at oracle.com] 
Sent: Dienstag, 20. Januar 2015 14:13
To: Lindenmaier, Goetz
Cc: 'hotspot-dev at openjdk.java.net'
Subject: Re: RFR (S): 8068026: [TESTBUG] Check for -client in gc/g1/TestHumongousCodeCacheRoots.java

On Tue, 2015-01-20 at 12:53 +0000, Lindenmaier, Goetz wrote:
> Hi Thomas,
> 
> yes, it would be better if the jtreg framework could sort it out right away.
> But in this case, you would get two very similar tests, one of which 
> would be executed always, thus not saving anything.

Not sure what you mean here: currently, the test starts three VMs, ie.
the main VM that executes two other VMs where one always fails if there
is no client VM.

With the proposed change, jtreg will only start the VMs that are
supported, i.e. either one or two.

>  Except for having
to adapt two tests if there is a change needed.

Since the meat of the code (TestHumongousCodeCacheRootsHelper) would be
in a shared class and the shells just forwarding to that, I do not see a
problem with such changes.
I would imagine that the code would get cleaner and smaller, because the
setup to execute the TestHumongousCodeCacheRootsHelper would go away.

> Also, it's been pushed in the meantime.
> http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/8dfd8b00c7f1

I did not notice that, somehow overlooked that - it was still on my
todo-list :) Sorry.

> Should I still improve the test?

It would be nice, but not that important I guess. I created an RFE at
https://bugs.openjdk.java.net/browse/JDK-8069343 to work on if you want.

Thanks,
  Thomas