RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests

[Lindenmaier, Goetz]

Hi Dmitry,

I agree it would be better if the test would not be started at all.
But I think this should be expressed in the tests.  The ProblemList
is not submitted to the repository, is it?  So how should somebody, 
who just checks out the repositories, know the test is expected to 
fail?

The change has been pushed in the meantime.

Thanks,
  Goetz.


-----Original Message-----
From: Dmitry Samersoff [mailto:dmitry.samersoff at oracle.com] 
Sent: Mittwoch, 21. Januar 2015 14:23
To: Lindenmaier, Goetz; Fredrik Arvidsson; hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests

Goetz,

Looks good for me (not a reviewer).

Platform.java:148 shouldSAAttach

This function is not intended to control whether SA is implemented or
not, it's just to check couple of well known conditions when attach
fails unexpectedly.

So it's better to return True (as it happens by default) for Aix and
manage SA related problem on different layers (ProblemList.txt, etc).

-Dmitry


On 2015-01-07 13:52, Lindenmaier, Goetz wrote:
> Thanks Fredrik!
> 
> Best regards,
>   Goetz.
> 
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Fredrik Arvidsson
> Sent: Mittwoch, 7. Januar 2015 11:18
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR(M): 8068013: [TESTBUG] Aix support in hotspot jtreg tests
> 
> Hi
> 
> The changes to the DynLibDcmdTest look good to me. I am not a reviewer 
> though, but I wrote that test some time ago.
> 
> /Fredrik
> 
> On 2015-01-07 11:14, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> A row of hotspot jtreg tests fail because support to test for Aix is missing.
>> To pass them, I would like to submit the following fixes:
>>
>> * runtime/6888954/vmerrors.sh: AIX can read from address '0', then throws SIGILL.
>> * serviceability/dcmd/DynLibDcmdTest.java: Just add check for Aix.
>> * test/test_env.sh: Add support for AIX. Sort OSes alphabetical.
>> * test/testlibrary/com/oracle/java/testlibrary/Platform.java: add isAix(). Sort OSes alphabetical.
>>
>> Please review this change, and I please need a sponsor.
>> http://cr.openjdk.java.net/~goetz/webrevs/8068013-jtregAix/webrev-01/
>>
>> Thanks and best regards,
>>    Goetz.
>>
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.