RFR(M): take2: 8086069: Adapt runtime calls to recent intrinsics to pass ints as long

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Jul 7 06:46:52 UTC 2015


Hi Vladimir, 

thanks a lot for pushing the two changes!

Best regards,
  Goetz.

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Montag, 6. Juli 2015 21:58
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): take2: 8086069: Adapt runtime calls to recent intrinsics to pass ints as long

Needs additional changes in our closed ports. I will push when they are reviewed.

Thanks,
Vladimir

On 7/2/15 6:59 AM, Lindenmaier, Goetz wrote:
> Thank you, John!
>
> Best regards,
>    Goetz.
>
> -----Original Message-----
> From: John Rose [mailto:john.r.rose at oracle.com]
> Sent: Donnerstag, 2. Juli 2015 01:35
> To: Lindenmaier, Goetz
> Cc: HotSpot Developers; Dean Long (dean.long at oracle.com)
> Subject: Re: RFR(M): take2: 8086069: Adapt runtime calls to recent intrinsics to pass ints as long
>
> That is much, much cleaner.  Thanks!  Reviewed.  — John
>
> On Jul 1, 2015, at 6:13 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
>>
>> Hi,
>>
>> I went back and had another look at this change.
>> As John proposed, I reworked it so that now the necessary sign extensions
>> are done in the native wrapper. These will not be subject to optimization,
>> but performance measurements showed no regressions.
>>
>> The change also removes the shared adaptions we did before.
>>
>> http://cr.openjdk.java.net/~goetz/webrevs/8086069-call_conv/webrev.02/
>> Could somebody please review this change?  I please need a sponsor.
>>
>> Best regards,
>>    Goetz
>


More information about the hotspot-dev mailing list