RFR 8130459(M): Add additional validation after heap creation

[gerard ziemski]

hi Kim,

I will add those 2 issues to JDK-8112746


cheers

On 07/22/2015 06:16 PM, Kim Barrett wrote:
> ------------------------------------------------------------------------------
> src/share/vm/runtime/globals.cpp
> 1248     CommandLineFlagRange* range = CommandLineFlagRangeList::at(i);
> 1249     const char* name = range->name();
> 1250     Flag* flag = Flag::find_flag(name, strlen(name), true, true);
> 1251     if (flag != NULL) {
>
> [Pre-existing code, though moved as part of this change.]
>
> I don't understand the need for the "if (flat != NULL) {" wrapper.
> Range objects are only created and registered with flags, so it
> shouldn't be possible for that test to ever fail.  Note that the
> constraint processing doesn't have such a test.
>
> [Doing anything about this should be a separate RFE, and this question
> is really directed more toward Gerard rather than Sangheon.]
>
> ------------------------------------------------------------------------------
> src/share/vm/runtime/globals.cpp
> 1213 bool CommandLineFlags::check_ranges() {
> 1214 //#define PRINT_RANGES_SIZES
> 1215 #ifdef PRINT_RANGES_SIZES
> ...
> 1274 static bool check_constraints(CommandLineFlagConstraint::ConstraintType constraint_type) {
> 1275 //#define PRINT_CONSTRAINTS_SIZES
> 1276 #ifdef PRINT_CONSTRAINTS_SIZES
>
> [More or less pre-existing code, though moved and updated as part of
> this change.]
>
> Do we really need this development cruft cluttering the code?
>
> [Doing anything about this should be a separate RFE, and this question
> is really directed more toward Gerard rather than Sangheon.]
>
> ------------------------------------------------------------------------------
>