RFR 8130459(M): Add additional validation after heap creation

[sangheon.kim]

Hi Kim,

Updated webrev includes:
- Moved functions related to range/constraints from CommandLineFlags to 
CommandLineFlagConstraintList / CommandLineFlagRangeList.
- 2 functions are changed to 'const'.
- 2 typos.

webrev.04:
http://cr.openjdk.java.net/~sangheki/8130459/webrev.04

Incremental:
http://cr.openjdk.java.net/~sangheki/8130459/webrev.04_to_03

Thanks,
Sangheon


On 07/23/2015 12:50 PM, Kim Barrett wrote:
> On Jul 23, 2015, at 2:26 PM, sangheon.kim <sangheon.kim at oracle.com> wrote:
>>>> Arguments::do_after_ergo (not wedded to this name)
>>>>    // --- maybe check_ranges call goes here?
>>>>    calls CommandLineFlagConstraintList::check_constraints with
>>>>      CommandLineFlagConstraint::AfterErgo
>>>>    calls post_after_ergo_constraint_check
>>>>
>>>> Or maybe that should just be at the end of apply_ergo?
>>>> Let me apply first suggestion.
>>> Let me apply first suggestion.
>> Sorry Kim, let me cancel my previous answer.
>> If we directly call CommandLineFlagConstraintList::check_constraints, we don't have layering problem.
>>
>> i.e. from Threads::create_vm().
>>   Arguments::apply_ergo();
>>   CommandLineFlagRangeList::check_ranges()
>> CommandLineFlagConstraintList::check_constraints(CommandLineFlagConstraint::AfterErgo);
>>   Arguments::post_after_ergo_constraint_check(constraint_result);
>>
>> How about this?
> That’s ok too.
>