RFR (XS): 8129855: -XX:+IgnoreUnrecognizedVMOptions hides "out of range" VM options.

[Vladimir Kozlov]

I think we need more detailed check in case of locked flags.
We should bailout only for product vs develop and product vs notproduct combinations (last 2 cases in 
get_locked_message()). For diagnostic and experimental flags we should exit with error message - this flags are 
available in product and most likely a developer forgot to add unlock flag. If we ignore them a test will be executed 
differently than intended.

Thanks,
Vladimir

On 7/30/15 8:18 AM, gerard ziemski wrote:
> hi all,
>
> Please review this small fix (also need a sponsor). It fixes IgnoreUnrecognizedVMOptions flag, so it’s now compatible
> with the new range/constraint check feature we put in recently. The current and desired/fixed behavior are:
>
> current JDK behavior:
>                                  exists, in range      exists, out of range   does not exist
>                                  -XX:StackRedPages=1 -XX:StackRedPages=0    -XX:THIS_FLAG_DOESNT_EXIST
> -IgnoreUnrecognizedVMOptions           OK ERR                    ERR
> +IgnoreUnrecognizedVMOptions           OK OK                     OK
>
>
>
> desired/fixed JDK behavior:
>                                  exists, in range      exists, out of range   does not exist
>                                  -XX:StackRedPages=1 -XX:StackRedPages=0
> -XX:THIS_FLAG_DOESNT_EXIST-IgnoreUnrecognizedVMOptions OK                    ERR                    ERR
> +IgnoreUnrecognizedVMOptions          OK ERR                    OK
>
>
> There was a brief email thread on this subject sometime ago
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-June/019213.html and it was decided that we need a new flag that
> provides a better alternative - that effort is now tracked by https://bugs.openjdk.java.net/browse/JDK-8132545
>
> Tested with test case from https://bugs.openjdk.java.net/browse/JDK-8130697,
> https://bugs.openjdk.java.net/browse/JDK-6886353 and via "JPRT testlist,noncolo.testlist -atk quick"
>
>
> References:
>
>     bug: https://bugs.openjdk.java.net/browse/JDK-8129855
> webrev: http://cr.openjdk.java.net/~gziemski/8129855_rev0/
>
>
> cheers