RFR: 8080947: Add uint as a valid VM flag type

[David Lindholm]

On 2015-06-02 14:56, Bengt Rutisson wrote:
> On 02/06/15 14:34, David Lindholm wrote:
>> On 2015-06-02 14:14, Bengt Rutisson wrote:
>>>
>>> Hi David,
>>>
>>> On 2015-05-28 13:28, David Lindholm wrote:
>>>> Hi,
>>>>
>>>> Please review this patch that adds uint and int as valid VM flag 
>>>> types. This patch adds the possibility to specify VM flags with 
>>>> types int and uint, it does not change the type of any flags.
>>>>
>>>>
>>>> Webrev: 
>>>> http://cr.openjdk.java.net/~david/JDK-8080947/webrev.hotspot.00/
>>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8080947/webrev.jdk.00/
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8080947
>>>
>>> Overall this looks good to me, but shouldn't Flag::get_uint() in 
>>> globals.cpp/hpp return an uint rather than an int?
>>>
>>>  113 int Flag::get_uint() const {
>>>
>>>  287   int get_uint() const;
>>
>> Good catch! I'll fix that. Do you need a new webrev?
>
> No need for a new webrev for that.


Thanks for the review Bengt.

/David


> Bengt
>
>>
>>
>> Thanks,
>> David
>>
>>> Thanks,
>>> Bengt
>>>
>>>
>>>
>>>>
>>>>
>>>> Testing: Passed JPRT
>>>>
>>>>
>>>> Thanks,
>>>> David
>>>
>>
>