Revision2: Corrected: RFR 8059557 (XL): Validate JVM Command-Line Flag Arguments

Kim Barrett kim.barrett at oracle.com
Wed Jun 3 19:37:02 UTC 2015


On Jun 2, 2015, at 6:52 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
> On May 27, 2015, at 5:28 PM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
>> 
>> hi all, 
>> 
>> Here is a revision 2 of the feature taking into account feedback from Dmitry, David, Kim and Alexander. 
>> ...
>> 
>> References: 
>> 
>>          Webrev: http://cr.openjdk.java.net/~gziemski/8059557_rev2 
>>            note: due to "awk" limit of 50 pats the Frames diff is not available for "src/share/vm/runtime/arguments.cpp” 
> 

One more:

------------------------------------------------------------------------------ 
src/share/vm/services/writeableFlags.cpp
46    for (int i=0; i<TEMP_BUF_SIZE-1; i++) {

That should be "j < TEMP_BUF_SIZE-1".  j is the index into the
range_string_no_whitespaces buffer that needs to be limited.

------------------------------------------------------------------------------




More information about the hotspot-dev mailing list