Revision2: Corrected: RFR 8059557 (XL): Validate JVM Command-Line Flag Arguments

Gerard Ziemski gerard.ziemski at oracle.com
Mon Jun 8 14:45:33 UTC 2015


Excellent catch. Thank you Derek!


On 6/5/2015 1:39 PM, Derek White wrote:
> On 5/27/15 5:28 PM, Gerard Ziemski wrote:
>> hi all,
>>
>> Here is a revision 2 of the feature taking into account feedback from 
>> Dmitry, David, Kim and Alexander.
>
> Hi Gerard,
>
> I was looking over Sangheon's table of GC arguments looking for easy 
> argument ranges to tighten, and saw an issue in your webrev:
>
> globals.hpp:
> 2013   manageable(intx, CMSTriggerInterval, 
> -1,                                  \
> 2014           "Commence a CMS collection cycle (at least) every so 
> many "       \
> 2015           "milliseconds (0 permanently, -1 
> disabled)")                      \
> 2016           range(-1, 0)
>
> The correct range is -1..max_intx.
>
>  - Derek
>
>



More information about the hotspot-dev mailing list