RFR: 8081607: Change default GC for server configurations to G1

Per Liden per.liden at oracle.com
Tue Jun 23 08:23:37 UTC 2015


Looks good, but could we remove the negation to make it easier to read, 
i.e. turn:

#if !defined(JAVASE_EMBEDDED)
       // Select G1 for non-embedded builds only.
       FLAG_SET_ERGO(bool, UseG1GC, true);
#else
       FLAG_SET_ERGO(bool, UseParallelGC, true);
#endif

into:

#if defined(JAVASE_EMBEDDED)
       FLAG_SET_ERGO(bool, UseParallelGC, true);
#else
       FLAG_SET_ERGO(bool, UseG1GC, true);
#endif

(No need to send out a new webrev for that)

cheers,
/Per

On 2015-06-23 10:07, Stefan Johansson wrote:
> Hi,
>
> Please review this change to make G1 the default GC:
> https://bugs.openjdk.java.net/browse/JDK-8081607
>
> JEP:
> http://openjdk.java.net/jeps/248
>
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8081607/hotspot.00/
>
> Summary:
> Changing the the default GC for server configurations to G1 (but not on
> embedded). Also updated test to reflect the change.
>
> Testing:
> * JPRT
> * Ad-hoc RBT runs, some issues found and fixed.
>
> Thanks,
> Stefan


More information about the hotspot-dev mailing list