Fix for 8122937: [JEP 245] Validate JVM Command-Line Flag Arguments breaks AArch64

[Gerard Ziemski]

hi Andrew,

You are correct.

jdk9/hotspot/src/cpu/aarch64/vm/globals_aarch64.hpp needs to have its  
ARCH_FLAGS macro table updated with "range" and "constraints" arguments.


cheers

On 6/23/2015 8:14 AM, Andrew Dinn wrote:
> I am trying to build the current hs-rt tree on AArch64 in order to test
> against Andrew Haley's UseCondCardMark patch (JDK-8079315). That tree
> now also includes the following fix for JDK-8122937:
>
>    http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/5bbf25472731
>
> The patch includes changes made to all the current cpus /except/ aarch64
> which means that the aarch64 build now falls over with
>
>
> /home/adinn/openjdk/hs-rt/hotspot/src/share/vm/runtime/globals_extension.hpp:242:28:
> error: macro "ARCH_FLAGS" passed 7 arguments, but takes just 5
>             IGNORE_CONSTRAINT)
>
> I believe the only modification required is to add the extra 2 arguments
> range and constraint to macro ARCH_FLAGS (as per most of the other
> cpu-specific globals files). I am testing this now and will raise a JIRA
> and submit a webrev if that is indeed all that is needed.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in UK and Wales under Company Registration No. 3798903
> Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters
> (USA), Michael O'Neill (Ireland)
>