RFR (XXS): 8129602: Incorrect GPL header causes RE script to create wrong output

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jun 24 16:03:03 UTC 2015


Hi Stefan, David, Coleen,

On Wed, 2015-06-24 at 07:16 -0400, Coleen Phillimore wrote:
> Thomas,
> 
> This looks good (in case you haven't already pushed it).  I think you 
> fixed your removal of the extra blank lines in the final 
> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.8u60/hotspot.patch 

Yes.

> patch.  I'm sorry I didn't address all of these issues when I did the 
> one assigned to me.   David pointed the other bugs out to me after I'd 
> started my JPRT job.
> 
> Now we know something will catch missing , at the end of copyright years.

:)

Thanks for the reviews. Note that there is another one of those up for
review, maybe if you had a second...

Thanks,
  Thomas




More information about the hotspot-dev mailing list