RFR(S): 8130036: Fix problems with imprecise C++ coding.

[Lindenmaier, Goetz]

Thanks!

Best regards,
  Goetz.

-----Original Message-----
From: Kim Barrett [mailto:kim.barrett at oracle.com] 
Sent: Montag, 29. Juni 2015 18:23
To: Lindenmaier, Goetz
Cc: HotSpot Developers; Zeller, Arno
Subject: Re: RFR(S): 8130036: Fix problems with imprecise C++ coding.

On Jun 29, 2015, at 4:30 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
> 
> Hi,
> 
> 
> 
> We detected some minor, but obviously wrong coding issues we would like to fix.
> 
> 
> 
> In two places {} are missing after an if, whilst there are two statements that depend
> 
> on the condition (CHECK macro expands to another statement).
> 
> 
> 
> In compilerOracle.cpp, a wrong size is passed to jio_snprintf().
> 
> 
> 
> Please review this change.  I please need a sponsor.
> 
> http://cr.openjdk.java.net/~goetz/webrevs/8130036_blocks/webrev.01/8130036_blocks-hs-rt.changeset
> 
> 
> 
> Best regards,
> 
>  Goetz.
> 
> Sorry for the resend, the subject was missing ...

Looks good.